Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-610] Converting Loading Inline kit to Typescrit #2328

Merged
merged 3 commits into from
Feb 24, 2023
Merged

[PLAY-610] Converting Loading Inline kit to Typescrit #2328

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
268a904
Converting Loading Inline kit to Typescrit
carloslimasd Feb 22, 2023
3d32937
Merge branch 'master' into PLAY-610-ts-conversion-loading-inline
carloslimasd Feb 24, 2023
8880a2c
Removing flow markdown
carloslimasd Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions playbook/app/pb_kits/playbook/pb_loading_inline/_loading_inline.jsx
View file
Open in desktop

This file was deleted.

57 changes: 57 additions & 0 deletions playbook/app/pb_kits/playbook/pb_loading_inline/_loading_inline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/* @flow */

import React from 'react'
import classnames from 'classnames'

import { buildAriaProps, buildCss, buildDataProps } from '../utilities/props'
import { globalProps } from '../utilities/globalProps'

import Body from '../pb_body/_body'
import Icon from '../pb_icon/_icon'

type LoadingInlineProps = {
align?: "left" | "center" | "right",
aria?: { [key: string]: string },
className?: string,
data?: { [key: string]: string },
id?: string,
}

const LoadingInline = (props: LoadingInlineProps) => {
const {
align = 'left',
aria = {},
className,
data = {},
id,
} = props

const ariaProps = buildAriaProps(aria)
const dataProps = buildDataProps(data)
const classes = classnames(
buildCss(`pb_loading_inline_kit_${align}`),
globalProps(props),
className
)

return (
<div
{...ariaProps}
{...dataProps}
className={classes}
id={id}
>
<Body color="light">
<Icon
aria={{ label: 'loading icon' }}
fixedWidth
icon="spinner"
pulse
/>
{' Loading'}
</Body>
</div>
)
}

export default LoadingInline
41 changes: 41 additions & 0 deletions playbook/app/pb_kits/playbook/pb_loading_inline/loading_inline.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import React from 'react'
import { render, screen } from '../utilities/test-utils'
import LoadingInline from './_loading_inline'

const testId = "loadingInline"

test('should render custom class and data', () => {
render(
<LoadingInline
className='custom-class'
data={{ testid: testId }}
/>
)

const kit = screen.getByTestId(testId)
expect(kit).toHaveClass('custom-class')
})

test('should render id', () => {
render(
<LoadingInline
data={{ testid: testId }}
id={testId}
/>
)

const kit = screen.getByTestId(testId)
expect(kit).toHaveProperty('id', testId)
})

test('should render aria-label', () => {
render(
<LoadingInline
aria={{ label: testId }}
data={{ testid: testId }}
/>
)

const kit = screen.getByTestId(testId)
expect(kit).toHaveAttribute('aria-label', testId)
})