Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-939] Section Separator Vertical Variant Fixes #3370

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[PLAY-939] Section Separator Vertical Variant Fixes #3370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be1d96
Force greater than 1 pixel
markdoeswork Apr 25, 2024
0f81bb8
Change dark dash color
markdoeswork Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions playbook/app/pb_kits/playbook/pb_section_separator/_section_separator.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ $section_colors_dark: (

&[class*=_dashed] {
&::before, &::after {
border: 1px dashed $border_light;
background: none;
@include section_separator_dashed(false);
}
}

Expand All @@ -66,5 +65,10 @@ $section_colors_dark: (
@include section_separator_vertical(true);
}
}
&[class*=_dashed] {
&::before, &::after {
@include section_separator_dashed(true);
}
}
}
}
12 changes: 11 additions & 1 deletion playbook/app/pb_kits/playbook/pb_section_separator/_section_separator_mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
content: "";
height: 100%;
width: 1px;
width: 1.9px;
position: initial;
z-index: 0;
}
Expand All @@ -21,3 +21,13 @@
background: $border_dark;
}
}

@mixin section_separator_dashed($dark: false) {
@if $dark == false {
border: 1px dashed $border_light;
background: none;
} @else {
border: 1px dashed $border_dark;
background: none;
}
}