Add handling for iOS in editor background/audio file selection #30999
+144
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
force-pushed
the
ios-hide-file-selector-popover
branch
from
ebfe417 to
33f3ba9
Compare
frenzibyte
changed the title
|
@frenzibyte test failures here look relevant, please have a check. |
|
I cannot repro locally and I found one commit that's outside of this branch which saw the same test failures: https://github.com/ppy/osu/actions/runs/12954965131/job/36138085475. Not entirely sure what the cause is, and I can't repo locally so it's hard for me to investigate. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the selection scope dialog and added
ISystemFileSelectorsupport:ScreenRecording_12-18-2024.10-35-52_1.mov
Since this is almost the main usage of file selectors and it's directly using
ISystemFileSelector, perhaps we don't really have to embedISystemFileSelectorwithinFileSelectoras done in ppy/osu-framework#6445. Not sure, not relevant to this PR anyway.