Add visual component for assigning user tags to beatmaps #32221
+756
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visual part for ppy#31913. Opening separately for appropriate visual UI adjustments. Also mostly ready to be hooked up to the results screen, pending merge of ppy/osu-web#11951.
notbakaneko
reviewed
Mar 4, 2025
|
Hmm, I think we're going to need a search box for tags (probably autofocused) selection, I guess that will be a follow-up effort? |
|
I'd honestly rather than do it here probably. It shouldn't be a huge undertaking. Unless you're uncomfortable with the diff size here I suppose. |
peppy
reviewed
Mar 8, 2025
Comment on lines
+377
to
+378
| voteCount.Value -= 1; | ||
| voted.Value = false; |
There was a problem hiding this comment.
I guess the only weird thing I've seen is that a tag returning to 0 count doesn't disappear and instead stays visible with a 0. Maybe fine, not sure.
Sounds fine. Diff so far is palatable so feel free to go ahead. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-03-04.13-10-41.mp4
Visual part for #31913. Opening separately for appropriate visual UI adjustments.
Also mostly ready to be hooked up to the results screen, pending merge of ppy/osu-web#11951 - but not hooked up quite yet.