Newlines filtered out on error messages?

[TomMD]

With let g:lsp_diagnostics_echo_cursor = 1 the full error message isn't visible.

For example, a multi-line message from LSP is:

/private/tmp/x/Main.hs:28:9: error:\n    • Couldn't match expected type ‘IO a0’ with actual type ‘Bool’\n    • In a stmt of a 'do' block: [ more snipped out ]

Even if I grow the command window what I see is a truncated version without newlines:

[TomMD]

OK, I see this is by design. If I change:

-        call lsp#utils#echo_with_truncation('LSP: '. substitute(l:diagnostic['message'], '\n\+', ' ', 'g'))
+        call lsp#utils#echo_with_truncation('LSP: '. l:diagnostic['message'])

and

-    if l:winwidth > 5 && l:winwidth < strdisplaywidth(l:msg)
-        let l:msg = l:msg[:l:winwidth - 5] . '...'
-    endif

Then I get almost the behavior I want. I can go down to escape the command bar but going up (k) doesn't work. Would you be up for a patch that adds some suitable global, like

let g:lsp_diagnostics_echo_cursor_full_message = 1
" Includes newline and does not truncate error messages when echoing.
" Must also have g:lsp_diagnostics_echo_cursor = 1

[TomMD]

Scratch all this actually. I very much prefer what you already have via

+ let g:lsp_diagnostics_float_cursor = 1 " float the diagnostics
+ let g:lsp_diagnostics_float_delay = 300

Sorry for the noise!