In code CRD validation #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justjkk
reviewed
Jul 21, 2020
| // validate check if the caller has set the right fields. | ||
| func validate(s *v1alpha1.WorkerPodAutoScaler) error { | ||
| if *s.Spec.MaxReplicas < 1 { | ||
| return fmt.Errorf("'max' is a required parameter and must be at least 1") |
There was a problem hiding this comment.
It might be useful to set max=0 sometimes (like when you want to temporarily disable processing of jobs). Also, we can put the static CRD validations like this one in the OpenAPI spec itself. min >= 0 and max >= 0 makes sense for me.
|
Will recreate a PR when i start working on it. This code is not getting executed. Need to figure out why. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in code CRD validation, since could not figure out quickly reading the docs on how to do it using the OpenAPIV3 spec. Created: https://stackoverflow.com/questions/62953678/openapiv3-conditional-validation-between-properties
Fixes #92