Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use DeliveryGuarantee enum as sink configuration #709

Closed
fyang86 opened this issue Nov 28, 2022 · 2 comments · Fixed by #713
Closed

Use DeliveryGuarantee enum as sink configuration #709

fyang86 opened this issue Nov 28, 2022 · 2 comments · Fixed by #713

Comments

@fyang86
Copy link
Contributor

fyang86 commented Nov 28, 2022

Problem description
Flink has already provided a enum DeliveryGuarantee to describe the delivery guarantee that our sink uses. We should leverage it instead of the current PravegaWriterMode enum.

Problem location
PravegaWriterMode, Sink

Suggestions for an improvement

@crazyzhou
Copy link
Contributor

For this task, we need to mark the writer mode API deprecated, and keep its compatibility for this release for now. We will consider removing the writer mode in the next one or two releases.

@crazyzhou
Copy link
Contributor

crazyzhou commented Jan 3, 2023

As the new Sink API is still marked experimental, we decide not changing the old Sink API to keep the compatibility, and directly change to use the DeliveryGuarantee and remove the writer mode support in the new Sink API.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants