Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

npm install fails with node v12 #120

Closed
ReinoutStevens opened this issue Sep 17, 2020 · 5 comments · Fixed by #159
Closed

npm install fails with node v12 #120

ReinoutStevens opened this issue Sep 17, 2020 · 5 comments · Fixed by #159
Assignees

Comments

@ReinoutStevens
Copy link

ReinoutStevens commented Sep 17, 2020

Describe the bug
npm i fails with node v12

You get a large list of errors like:
../src/fibers.cc:68:2: error: ‘Handle’ does not name a type

The suggested solution is to install g++ build essentials, which were already present.

To Reproduce

  • remove node_modules ( or get a fresh copy of this repo )
  • use node v12 ( tested with v12.17.0 and v12.18.4 )
  • npm i

Expected behavior
Expect everything to get installed :)

Desktop (please complete the following information):

  • OS: Ubuntu 2020.04

Additional context
Using Node v10 works fine, and after installing you can just switch to node v12 without any issue

@GLStephen
Copy link
Contributor

Try deleting your package-lock and using 'npm ci'.

@ReinoutStevens
Copy link
Author

I assume you mean deleting your node_modules, and doing npm ci, as deleting your package-lock is not appreciated by npm ci.

Same error persists in this case.

@GLStephen
Copy link
Contributor

@ReinoutStevens yeah

  1. rm ./package-lock.json
  2. git checkout package-lock.json
  3. npm ci

@ReinoutStevens
Copy link
Author

ReinoutStevens commented Sep 17, 2020

Yeah thats what I did after npm ci complained that it requires a package-lock file :)
Fails both on master and 1.8.0

This is in a freshly cloned copy of the repo without any modifications

@dgirardi
Copy link
Collaborator

dgirardi commented Mar 9, 2022

This should be fixed by #159

@dgirardi dgirardi moved this from Triage to PR submitted in Prebid.js Tactical Issues table Mar 9, 2022
@dgirardi dgirardi self-assigned this Mar 14, 2022
@dgirardi dgirardi moved this from PR submitted to No reviewers in Prebid.js Tactical Issues table Mar 29, 2022
Repository owner moved this from No reviewers to Done in Prebid.js Tactical Issues table Apr 7, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
3 participants