Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Native ads do not trigger AD_RENDER_SUCCEEDED / AD_RENDER_FAILED #182

Closed
dgirardi opened this issue Oct 4, 2022 · 1 comment · Fixed by #199
Closed

Native ads do not trigger AD_RENDER_SUCCEEDED / AD_RENDER_FAILED #182

dgirardi opened this issue Oct 4, 2022 · 1 comment · Fixed by #199
Assignees
@dgirardi
Labels
enhancement New feature or request

Comments

@dgirardi
Copy link
Collaborator

dgirardi commented Oct 4, 2022 •
edited by patmmccann
Loading

Describe the bug

Rendering a native ad does not trigger the AD_RENDER_SUCCEEDED & FAILED event like banner ads do.

To Reproduce
Steps to reproduce the behavior:

Render any ad through the PUC native-render.js.
@dgirardi dgirardi mentioned this issue Oct 11, 2022
Merged
@patmmccann
Copy link
Contributor

Aside: succeeded is rather misleading, we may want to rename 'attempted' or similar

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Oct 24, 2022
@dgirardi dgirardi moved this from Ready for Dev to In progress in Prebid.js Tactical Issues table Dec 20, 2022
@patmmccann patmmccann linked a pull request Jan 18, 2023 that will close this issue
Emit AD_RENDER_SUCCEEDED and AD_RENDER_FAILED for native ads #199
Merged
@patmmccann patmmccann moved this from In progress to PR submitted in Prebid.js Tactical Issues table Jan 18, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Sep 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dgirardi dgirardi

Labels
enhancement New feature or request
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit AD_RENDER_SUCCEEDED and AD_RENDER_FAILED for native ads dgirardi/prebid-universal-creative
2 participants
@patmmccann @dgirardi