Skip to content

Contents of the system tests archive #400

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
4 tasks done
MakisH opened this issue Nov 19, 2023 · 2 comments · May be fixed by #629
Open
4 tasks done

Contents of the system tests archive #400

MakisH opened this issue Nov 19, 2023 · 2 comments · May be fixed by #629

Comments

@MakisH
Copy link
Member

MakisH commented Nov 19, 2023

Example of the contents of an archive:

Screenshot from 2023-11-19 21-48-16

I think we still need some changes:

  • reference_results and reference-data seems to be confusing (which is what?). One of them needs to be renamed, maybe to results_to_compare.
  • What is the tutorials_ref? It currently contains master, but in that job, I had asked for develop (see Cannot checkout tutorials develop in tests #399).
  • The actual git commits of each repository are not reported anywhere. See Report git hash of each repository #401
  • Do we need the metadata.yaml, docker-compose.tutorial.yaml, and docker-compose.field_compare.yaml? Are they only useful for debugging the system tests themselves? I would suggest to either delete them, or move them to a subfolder (e.g., system-tests-debug).

cc @valentin-seitz

@MakisH MakisH changed the title System tests: Contents of the archive Contents of the system tests archive Nov 19, 2023
@valentin-seitz
Copy link
Contributor

valentin-seitz commented Nov 25, 2023

* [ ]  Do we need the `metadata.yaml`, `docker-compose.tutorial.yaml`, and `docker-compose.field_compare.yaml`? Are they only useful for debugging the system tests themselves? I would suggest to either delete them, or move them to a subfolder (e.g., `system-tests-debug`).

One of the big benefits of using containers is, that its very easy to "debug" a problem with a precice component, without having to install all of them manually. So having the docker-compose.tutorial.yaml and the fieldcompare.yaml is a crucial step in reproducing the failed pipeline in your local machine. So i would def. keep them around. A related Issue is: #387 where we need to move some absolute paths into relative ones to allow this "debug the pipeline in your local machine" feature.

@MakisH
Copy link
Member Author

MakisH commented Nov 27, 2023

Then, let's focus on what is currently not included (or how it is named), and remove stuff later.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants