Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Controller with "log" in pathname excluded from scan #1830

Closed
scottwillson opened this issue Feb 8, 2024 · 1 comment · Fixed by #1880
Closed

Controller with "log" in pathname excluded from scan #1830

scottwillson opened this issue Feb 8, 2024 · 1 comment · Fixed by #1880
Milestone

Comments

@scottwillson
Copy link

Background

Brakeman version: 5.4.1
Rails version: 6.1.7
Ruby version: 2.7.7

Issue

Some controllers are being skipped and not scanned because they are in a directory ending in "log'. E.g., app/controllers/n/off_catalog/orders_controller.rb is excluded in AppTree#reject_global_excludes because "log/" is in EXCLUDED_PATHS.

Changing "log/" to "/log/" in EXCLUDED_PATHS fixes this but I'm unsure if that would cause other issues.

@presidentbeef
Copy link
Owner

🤦

I think all those paths should be updated with leading forward slashes. I don't think it will cause any issues.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants