fix(psl): fix a typo in feature gates for schemas_completion
#5200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function should be enabled for `mssql`, not `mysql`. It happened to work despite the typo because ultimately the completions are only used by the language server via `prisma-schema-wasm`, which compiles `psl` with all features enabled. However, when `psl` was compiled with `mysql` feature only (as part of MySQL specific builds of `query-engine-wasm` and `query-compiler-wasm`) this led to a dead code warning.
CodSpeed Performance ReportMerging #5200 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
jacek-prisma
approved these changes
Feb 27, 2025
jkomyno
approved these changes
Feb 27, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function should be enabled for
mssql, notmysql. It happened to work despite the typo because ultimately the completions are only used by the language server viaprisma-schema-wasm, which compilespslwith all features enabled. However, whenpslwas compiled withmysqlfeature only (as part of MySQL specific builds ofquery-engine-wasmandquery-compiler-wasm) this led to a dead code warning.