feat: Azure Functions v4 support #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
reviewed
Dec 8, 2023
tsconfig.json
Outdated
There was a problem hiding this comment.
do we need a tsconfig file given that this is a JS project? Is index.d.ts generated or did you hand craft it? If we need it, shouldn't it be a jsconfig.json file instead?
There was a problem hiding this comment.
The index.d.ts file was generated, following docs at https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html, which describe adding tsconfig.json. I did try jsconfig.json but using that creates the following error:
azure-function-v4.js
Outdated
| await probot.webhooks.verifyAndReceive({ | ||
| id: request.headers.get("X-GitHub-Delivery"), | ||
| name: request.headers.get("X-GitHub-Event"), | ||
| signature: request.headers.get("X-Hub-Signature-256") || request.headers.get("X-Hub-Signature"), |
There was a problem hiding this comment.
I don't think there is any GHES version left that sends out the X-Hub-Signature header, I think we can just leave it out.
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new function
azureFunctionV4to support Azure Functions v4.Main interface changes:
azure-function-v4.js: Added a new functionazureFunctionV4to handle incoming webhook requests from GitHub and verify their authenticity usingprobot.webhooks.verifyAndReceive.index.js: Added a new functioncreateAzureFunctionV4. [1]Documentation changes:
README.md: Added instructions for usingcreateAzureFunctionV4function, including an example of creating an Azure Function using@probot/adapter-azure-functionspackage.