Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ensure Pyright version is the same in pre-commit and CI #984

Closed
ewjoachim opened this issue Mar 14, 2024 · 0 comments · Fixed by #985
Closed

Ensure Pyright version is the same in pre-commit and CI #984

ewjoachim opened this issue Mar 14, 2024 · 0 comments · Fixed by #985

Comments

@ewjoachim
Copy link
Member

In pre-commit we're using https://github.com/RobertCraigie/pyright-python:

- repo: https://github.com/RobertCraigie/pyright-python
rev: v1.1.353
hooks:
- id: pyright
additional_dependencies:
- aiopg==1.4.0
- anyio==4.3.0
- asgiref==3.7.2
- attrs==23.2.0
- croniter==2.0.2
- django==4.2.11
- django-stubs==4.2.7
- importlib-resources==6.1.3
- psycopg[pool]==3.1.18
- psycopg2-binary==2.9.9
- python-dateutil==2.9.0.post0
- sqlalchemy==2.0.28
- typing-extensions==4.10.0

In the CI we're using jakebailey/pyright-action@v2:

- uses: jakebailey/pyright-action@v2

We should try to make sure both use the same pyright version and this version is updated by Renovate.

There's a ticket in the GHA action to tie the version to a package.json. Maybe we could use a pre-commit script to ensure pre-commit uses the same version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant