Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improved TAS support in AppWrappers #314

Open
dgrove-oss opened this issue Feb 7, 2025 · 0 comments
Open

Improved TAS support in AppWrappers #314

dgrove-oss opened this issue Feb 7, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@dgrove-oss
Copy link
Collaborator

The initial TAS support is black box. It just does the minimum of propagating the annotations on each PodSetTemplate, but looses any rank/ordering that are implied by the Kind that is being wrapped.

For PyTorchJob, Job, JobSet, etc. this is suboptimal. We should instead construct the TopologyRequest portion of the PodSetInfo on the AppWrapper side where we can customize what we are doing based on the specific Kind being processed.

@dgrove-oss dgrove-oss added the enhancement New feature or request label Feb 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant