Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use a different library for websockets connections #197

Open
ghjm opened this issue Apr 2, 2020 · 2 comments
Open

Use a different library for websockets connections #197

ghjm opened this issue Apr 2, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@ghjm
Copy link
Contributor

ghjm commented Apr 2, 2020

The aiohttp library does not support https proxy servers, which is something we would like to have. A new library, python-httpx (https://www.python-httpx.org/), appears to support websockets over https proxies. We should investigate whether it is feasible to switch to this library and, if so, whether its ws/wss-over-https implementation will work for us.
@ghjm ghjm added the enhancement New feature or request label Apr 2, 2020
@ghjm ghjm mentioned this issue Apr 2, 2020
Closed
@chrismeyersfsu
Copy link

We chose aiohttp for AWX because runner uses aiohttp :(

@ghjm
Copy link
Contributor Author

ghjm commented May 1, 2020

Who's the more foolish, the fool or the fool who follows him?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrismeyersfsu @ghjm