Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Receptor ping --count 0 implies --delay 0 #209

Open
ghjm opened this issue Apr 21, 2020 · 4 comments
Open

Receptor ping --count 0 implies --delay 0 #209

ghjm opened this issue Apr 21, 2020 · 4 comments
Labels
bug Something isn't working needs_test This item needs to be tested
Milestone

Comments

@ghjm
Copy link
Contributor

ghjm commented Apr 21, 2020

receptor ping foo uses the default of four pings with a one-second delay.
receptor ping foo --count 0 unexpectedly pings as fast as possible, with no delay.
receptor ping foo --count 0 --delay 10 ignores the delay and still pings as fast as possible.

Expected behavior: delay should be one second unless specified, and when specified, should be respected.

@ghjm ghjm added the bug Something isn't working label Apr 21, 2020
@elyezer
Copy link
Member

elyezer commented Apr 22, 2020

Do we want to set a minimum delay allowed? Like, do we want to support no delay pings and maybe overload the mesh?

@ghjm
Copy link
Contributor Author

ghjm commented Apr 22, 2020

I think it's useful to allow flood pings for certain troubleshooting scenarios, but you should have to do it explicitly with --delay 0.

@elyezer
Copy link
Member

elyezer commented Apr 22, 2020

That is a good point and I agree with it.

@matburt matburt added this to the 1.0 Release milestone May 13, 2020
@ghjm
Copy link
Contributor Author

ghjm commented May 15, 2020

Fixed by ansible/receptor#223

@ghjm ghjm added the needs_test This item needs to be tested label May 15, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working needs_test This item needs to be tested
Projects
None yet
Development

No branches or pull requests

3 participants