Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade node version to 14 #41

Closed
lnpotter opened this issue Mar 6, 2023 · 5 comments · Fixed by #46
Closed

Upgrade node version to 14 #41

lnpotter opened this issue Mar 6, 2023 · 5 comments · Fixed by #46
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@lnpotter
Copy link
Contributor

lnpotter commented Mar 6, 2023

There are several benefits to updating from Node.js version 10 to version 14.

  • Firstly, Node.js 14 includes significant improvements in performance and memory usage over Node.js 10. This means that applications running on Node.js 14 can handle more requests and users with less memory and CPU usage.

  • Secondly, Node.js 14 includes many new features and updates to the standard library, including improvements to the V8 engine, support for ECMAScript modules, and improvements to the core APIs. These updates make it easier and more efficient to develop applications with Node.js, and provide better support for modern JavaScript syntax and features.

  • Thirdly, Node.js 14 includes a number of security (CVE-2020-11080, CVE-2019-9511, CVE-2019-9512, CVE-2019-9513, CVE-2020-8172, CVE-2021-23337) updates and bug fixes that have been implemented since version 10 was released.

  • Finally, to security fixes, Node.js 14 also introduced improvements to memory management, including better handling of memory leaks and a new garbage collector that can more effectively reclaim memory from idle objects.

This is just a suggested version upgrade. You may want to consider the current LTS as well.

@Cynosphere
Copy link
Contributor

LTS is the smarter and safer option from my own experience (which is currently Node.js 18 as of writing). Node.js 19 is a whole other set of issues that will have to be dealt with later though.

@TTtie TTtie added the type: enhancement New feature or request label Mar 6, 2023
@TTtie TTtie added this to the 0.2.0 milestone Mar 6, 2023
@TTtie TTtie self-assigned this Mar 6, 2023
@lnpotter
Copy link
Contributor Author

lnpotter commented Mar 6, 2023

Yes, indeed. I believe version 18 is more appropriate as well, because it is the current LTS and has many more benefits included in it.

@TTtie
Copy link
Member

TTtie commented Mar 6, 2023

Bumping the minimal Node version is definitely planned for v0.2.0.

Which version to bump to should be subject to further discussion – it for sure won't be v14, as that's going to become EOL at the end of April.

As I see it, v16 should be the safest at the time of writing, although it is only supported until September this year.

@lnpotter
Copy link
Contributor Author

lnpotter commented Mar 6, 2023

I keep on "banging on the button" that version 18 should be the one being considered. Since it is the LTS, and has a longer support than the other previous versions, it already helps new people to get familiar with the new functioning of classes (encapsulation) and reduces unnecessary work in the future if private methods are used for the library to handle internal processes.

edit: Not only these, but other methods have also undergone changes, breaking changes and improvements, so I believe that version 18 should be considered.

@lnpotter
Copy link
Contributor Author

lnpotter commented Mar 6, 2023

If Abal's behavior is followed, which was basically to keep the library at version 10 because there was no need to update (even though there was a LOT) then it would be more interesting to keep at version 14. However, if one of the benefits is to be able and require the need for Node in a newer version, then version 18 might be better.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants