Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix up min/max identifiers #1604

Open
SuperQ opened this issue Aug 30, 2024 · 3 comments
Open

Fix up min/max identifiers #1604

SuperQ opened this issue Aug 30, 2024 · 3 comments
Labels
chore good first issue help wanted

Comments

@SuperQ
Copy link
Member

SuperQ commented Aug 30, 2024

Go now includes min and max in the list of predeclared identifiers. These need to be renamed.

Followup to #1603
@parthlaw
Copy link
Contributor

parthlaw commented Aug 30, 2024 •
edited
Loading

May I take on this issue?

@SuperQ
Copy link
Member Author

SuperQ commented Aug 31, 2024

Of course, you don't need to ask permission to work on open source.

@parthlaw parthlaw mentioned this issue Aug 31, 2024
Merged
@parthlaw
Copy link
Contributor

@SuperQ please take a look at the PR and let me know if this is the solution that we were looking for.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
chore good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SuperQ @parthlaw