Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pronto doesn't run without being in a git repo and providing a path #357

Open
enthusiasmus opened this issue Sep 27, 2019 · 0 comments
Open

Comments

@enthusiasmus
Copy link

enthusiasmus commented Sep 27, 2019

Is it possible to run pronto with its runner without path by only being inside a git repository? For only the third and last (out of three) commands works.

root@27dc4bb0fd5d:/# ls
app  bin  boot	dev  etc  home	lib  lib64  media  mnt	opt  proc  root  run  sbin  srv  sys  tmp  usr	var
root@27dc4bb0fd5d:/# pronto run app
root@27dc4bb0fd5d:/# cd app
root@27dc4bb0fd5d:/app# ls
Capfile		  README.md	   cat.diff	  docker			    docker-compose.xxx.yml			  lib			postcss.config.js    spec
Dockerfile	  Rakefile	   config	  docker-compose-ci.yml		    docker-compose.override-asset-production.yml  local_categories.txt	prod_categories.txt  tmp
Dockerfile-MySQL  app		   config.ru	  docker-compose.xxx-test.yml  docker-compose.override.yml			  log			public		     vendor
Gemfile		  babel.config.js  config_volume  docker-compose.xxx.yml	    docker-compose.production.yml		  node_modules		schema.graphql	     yarn.lock
Gemfile.lock	  bin		   db		  docker-compose.xxx-test.yml  docker-compose.yml				  package.json		script
root@27dc4bb0fd5d:/app# pronto run
root@27dc4bb0fd5d:/app# pronto run app
app/helpers/core/controller_helpers.rb:6 W: Metrics/MethodLength: Method has too many lines. [11/10]
app/helpers/core/controller_helpers.rb:26 W: Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.
app/helpers/core/controller_helpers.rb:31 W: Style/GuardClause: Use a guard clause (`return unless try_spree_current_user && @order`) instead of wrapping the code inside a conditional expression.
app/helpers/core/controller_helpers.rb:31 W: Rails/HelperInstanceVariable: Do not use instance variables in helpers.
app/helpers/core/controller_helpers.rb:32 W: Rails/HelperInstanceVariable: Do not use instance variables in helpers.
app/helpers/core/controller_helpers.rb:32 W: Rails/HelperInstanceVariable: Do not use instance variables in helpers.
app/helpers/core/controller_helpers.rb:33 W: Rails/HelperInstanceVariable: Do not use instance variables in helpers.
app/helpers/core/controller_helpers.rb:51 W: Metrics/CyclomaticComplexity: Cyclomatic complexity for set_current_order is too high. [7/6]
app/helpers/core/controller_helpers.rb:51 W: Metrics/PerceivedComplexity: Perceived complexity for set_current_order is too high. [8/7]
app/helpers/core/controller_helpers.rb:63 W: Rails/HelperInstanceVariable: Do not use instance variables in helpers.

I would like to cd into the root of my project directory and execute pronto run without providing a path.

Further informations:

root@27dc4bb0fd5d:/app# pronto -v
0.10.0
root@27dc4bb0fd5d:/app# rubocop -v
0.74.0

Thanks for feedback,
best regards,
Lukas

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant