Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make default max_warnings finite and reasonably low #458

Open
Vasfed opened this issue Jan 29, 2024 · 0 comments
Open

Make default max_warnings finite and reasonably low #458

Vasfed opened this issue Jan 29, 2024 · 0 comments

Comments

@Vasfed
Copy link
Contributor

Vasfed commented Jan 29, 2024

When not explicitly set via PRONTO_MAX_WARNINGS or in config, max_warnings is infinite.
This is potentially dangerous, because couple thousands comments can lead to DOS on on-premise gitlab (it's sidekiq becomes flooded with NewNoteWorker/Integrations::ExecuteWorker, also lots of emails are sent and there's a risk of becoming banned by email server for spam), api rate limit hits on other providers etc.

Setting default max_warnings to some reasonable value (150..300..500?) with an ability to explicitly opt-in to infinity seems like a more safe solution.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant