Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Misleading output of "No issues found!" when a model is skipped #218

Open
peng-hui opened this issue Oct 30, 2024 · 0 comments
Open

Misleading output of "No issues found!" when a model is skipped #218

peng-hui opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@peng-hui
Copy link

Describe the bug
Modelscan skips a model if it identifies invalid magic number (header) of the model. However, it would still print out

 --- Summary ---

 No issues found! 🎉

--- Skipped ---

Total skipped: 1 - run with --show-skipped to see the full list.

This is kind of misleading because incautious users might ignore the line about the skipped model.

I understand the modelscan produces a different non-zero exit code but I suppose people might not check the exit code.

To Reproduce
Steps to reproduce the behavior:

  1. run on a model with an invalid magic number, for example: https://huggingface.co/sentence-transformers/paraphrase-MiniLM-L6-v2/blob/main/openvino/openvino_model.bin
  2. modelscan -p openvino_model.bin

Expected behavior
I would expect modelscan to show: modelscan does not know if there is an issue because the model is skipped.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context
Add any other context about the problem here.

@peng-hui peng-hui added the bug Something isn't working label Oct 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant