Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable rules using "off" instead of "false" #43

Closed
fvictorio opened this issue May 12, 2018 · 5 comments
Closed

Disable rules using "off" instead of "false" #43

fvictorio opened this issue May 12, 2018 · 5 comments
Labels
good first issue Good candidate for newcomers :) help wanted Team would love to have contributors working on these to do

Comments

@fvictorio
Copy link
Contributor

In order to make solhint more compatible with eslint, we should allow disabling rules using the value "off" instead of using false. We can make this change backward-compatible and, ideally, show a deprecated message for configurations that use false.

@fvictorio fvictorio added help wanted Team would love to have contributors working on these good first issue Good candidate for newcomers :) labels May 12, 2018
@idrabenia
Copy link
Contributor

Hi, It's break backward compatibitilies.

I think it make sense to concentrate on business features instead of this small improvements

@fvictorio
Copy link
Contributor Author

I meant we could have both options, so that it's backwards compatible. I think a lot of users coming from eslint are used to using "off" instead of false (I myself tried to do it).

I agree that this is low priority, but it's the kind of thing that someone looking to collaborate could use as a first issue.

@pablofullana
Copy link
Contributor

pablofullana commented Jan 10, 2019

Now that we have 2.0 about to be released, and for the sake of simplicity, why don't we simply get rid of false and stick to 0 | 'off'? (keeping in mind that we wanna mimic eslint behavior when possible).

@fvictorio
Copy link
Contributor Author

Yes please.

@fvictorio
Copy link
Contributor Author

For the record: 0 and 'off' are still valid. Since we already published 2.0, the only thing we can do is deprecate them.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good candidate for newcomers :) help wanted Team would love to have contributors working on these to do
Projects
None yet
Development

No branches or pull requests

3 participants