Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Offer test account statements for code test of exchange integrations #19

Open
wearymanateevedaknotstabooresisting opened this issue Mar 6, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@wearymanateevedaknotstabooresisting
Copy link
Contributor

Hereby, I request to offer artificial account statements (best, real statements with altered data), to test exchange integrations regarding valid implementation.

This includes the by-hand calculation of taxes with respect to the applicable law which is supported.

It should be noted, that all supported tax laws should be tested with each integration. Best, in a combined test file, which is the real world use-case when exporting exchange activity by users.

@wearymanateevedaknotstabooresisting wearymanateevedaknotstabooresisting changed the title Offer tests account statements for code test of exchange integrations Offer test account statements for code test of exchange integrations Mar 7, 2021
@shredEngineer
Copy link
Contributor

I don't have by-hand calculation of taxes, but here are my test account statements for Kraken (new format), which I also uploaded in some other issue here. Maybe this is useful to someone.
kraken-example-ledgers.csv.txt
kraken-example-trades.csv.txt

@wearymanateevedaknotstabooresisting
Copy link
Contributor Author

Thanks, that provides a bare minimum test. I guess we'd need one for every exchange (times) tax law application

@provinzio provinzio added the help wanted Extra attention is needed label Mar 14, 2021
@sibbl
Copy link
Contributor

sibbl commented Mar 16, 2021

I'd also like to share some data as I found some limitations for Coinbase and Binance with it already. I'm still trying to get at least one end-to-end run finish successfully before I can contribute though...

Would it also make sense to think about writing unit tests using this data?

@provinzio
Copy link
Owner

provinzio commented Mar 16, 2021

It would be awesome to provide unit testing.

Definitly a point we have to take a deeper look into. I think that it'll make everybody sleep better, if they know that we tested the code extensivly and continuously.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants