Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

G1 G-code parsing is broken leading to import hang #119

Open
LeadAssimilator opened this issue Nov 26, 2018 · 1 comment
Open

G1 G-code parsing is broken leading to import hang #119

LeadAssimilator opened this issue Nov 26, 2018 · 1 comment

Comments

@LeadAssimilator
Copy link

Broken G1

The G1 G-code must have at least one parameter, but the PursaControl parsing code, namely gcode.py's parse_g1_line_new, is expecting at least two when the first parameter is Y, and throws an exception that is uncaught, breaking loading and the UI.

When only X is present, the entire G-code is ignored.

Examples

G1 X179.750 ; I will be completely ignored
G1 Y185.250 ; I will exception and break loading and the UI

Workarounds

If you experience any issues with importing gcode files it is more than likely G1 or some other code that is not properly handled. It can usually be worked around by adding dummy parameters to the affected codes, or stop using PrusaControl since it appears to be broken and dead.

@prusa3d-bb
Copy link

prusa3d-bb commented Nov 26, 2018 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants