Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

check against RX overflow in rftxrx_isr? #22

Closed
ecc1 opened this issue Feb 21, 2016 · 1 comment
Closed

check against RX overflow in rftxrx_isr? #22

ecc1 opened this issue Feb 21, 2016 · 1 comment

Comments

@ecc1
Copy link
Contributor

ecc1 commented Feb 21, 2016

I don't see any check that radio_rx_buf_len hasn't exceeded MAX_PACKET_LEN when you read an incoming byte. If you're getting a lot of noise, isn't it possible that it will overrun while you're still looping in get_packet_and_write_to_serial?

@ps2
Copy link
Owner

ps2 commented Apr 4, 2016

Didn't see this until now, for some reason, but yes, it looks like that's possible. Thanks for the heads up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants