Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow Backup tasks in Schedules to be blocking #4796

Closed
1 task done
zediious opened this issue Jun 1, 2023 · 2 comments
Closed
1 task done

Allow Backup tasks in Schedules to be blocking #4796

zediious opened this issue Jun 1, 2023 · 2 comments
Labels
feature request A request for a new feature.

Comments

@zediious
Copy link

zediious commented Jun 1, 2023

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

I would like for Schedules to pause their execution/be blocked when they reach a Backup task, until the backup task has been completed. Often, I need to run commands before and after the backup has completed. Since the scheduler immediately goes to the next task (after whatever time offset you set), I cannot accurately predict when the backup will complete and run commands at the right time.

Describe the solution you'd like.

This could be a default functionality, or something that can be enabled per backup task. Essentially, a checkmark within the Backup task labelled "Make task blocking" or something along those lines would be perfect in my mind.

The solution I'm employing now is simply setting a large offset after the backup. It's possible that the backup could exceed this time though, and that leaves me uneasy.

Additional context to this request.

I tested this by running the following schedule;
Screenshot_1742

The save-on command is run exactly 7 seconds after say [AUTO-BACKUP] Server backup is beginning now. World saving will be off until completion. is run, so it seems that the backup task is immediately moved on from, even though it's still running.

@zediious zediious added the feature request A request for a new feature. label Jun 1, 2023
@Boy132
Copy link
Contributor

Boy132 commented Jun 1, 2023

Duplicate of #2872

@zediious
Copy link
Author

zediious commented Jun 1, 2023

Duplicate of #2872

Whoops! Was not thorough enough in my search evidently.

@trenutoo trenutoo closed this as completed Jun 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature request A request for a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants