Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inputs Number und Range: onChange Value Type nicht konsistent #6345

Open
3 tasks
laske185 opened this issue Apr 23, 2024 · 2 comments
Open
3 tasks

Inputs Number und Range: onChange Value Type nicht konsistent #6345

laske185 opened this issue Apr 23, 2024 · 2 comments
Labels
v3 Here are issues that need to be resolved for version 3.

Comments

@laske185
Copy link
Contributor

laske185 commented Apr 23, 2024

KolInputRange emitted zur Zeit number, KolInputNumber emitted string.

Sollte dies auf einen einheitliches Type angepasst werden?

Gedanken zu number vs. string:

  • Der DOM Standard ist string, das ist also auch der Type mit dem Entwickler i.d.R. rechnen werden.
  • Mit string sind auch Eingaben wie '010' möglich: Kein Integer, aber immer noch eine Nummer. Mit number würde dies zu 10 konvertiert werden.

Todo

  • API bei kol-input-range umstellen auf String
  • Breaking Change dokumentieren (Liste für V3)
  • Event-Dokumentation in Readme anpassen, Link auf dieses Issue entfernen
@laske185 laske185 converted this from a draft issue Apr 23, 2024
@laske185 laske185 added the v3 Here are issues that need to be resolved for version 3. label Apr 23, 2024
@laske185 laske185 moved this to 📄 Ready in KoliBri Board Apr 23, 2024
@laske185 laske185 moved this from 📄 Ready to Backlog in KoliBri Board May 2, 2024
@laske185 laske185 moved this from Backlog to 📄 Ready in KoliBri Board May 2, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This issue has been automatically marked as stale and will be closed in 10 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, please post a comment or remove the Stale label.

@github-actions github-actions bot added the Stale label Nov 4, 2024
Copy link
Contributor

This issue was closed because it has been stale for 10 days with no activity. If the issue is still relevant to you, feel free to re-open with a comment.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2024
@github-project-automation github-project-automation bot moved this from 📄 Ready to ✅ Done in KoliBri Board Nov 14, 2024
@laske185 laske185 reopened this Dec 10, 2024
@github-actions github-actions bot removed the Stale label Dec 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
Archived in project
Development

No branches or pull requests

1 participant