-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
wrap setting err.message with a try/catch #2996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this attempts to bypass pugjs#2995 (a continuation of pugjs/pug-runtime#35) note that this does not fix the bug. if setting `err.message` throws an error, the reason for that should be found and corrected.
Can you update the tests. You can usually do this by running |
@ForbesLindesay I tried running I merged in
|
ForbesLindesay
approved these changes
May 1, 2020
pug-runtime (2.0.5 → 2.0.6)Bug Fixes
Packages With No ChangesThe following packages have no user facing changes, so won't be released:
|
This was referenced Mar 11, 2021
Merged
This was referenced Mar 15, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this attempts to bypass #2995 (a continuation of pugjs/pug-runtime#35)
note that this does not fix the bug. if setting
err.message
throws an error, the reason for that should be found and corrected.