Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pin djangorestframework to 3.15.1 #5978

Open
Odilhao opened this issue Nov 4, 2024 · 3 comments
Open

Pin djangorestframework to 3.15.1 #5978

Odilhao opened this issue Nov 4, 2024 · 3 comments
Labels

Comments

@Odilhao
Copy link

Odilhao commented Nov 4, 2024

Right now djangorestframework to 3.15.2 ships with one dir that was intent to be created only by the documentation example:

├── djangorestframework.egg-info
├── LICENSE.md
├── MANIFEST.in
├── PKG-INFO
├── README.md
├── rest_framework
├── setup.cfg
├── setup.py
├── tests
└── tutorial
 tree tutorial/
tutorial/
├── asgi.py
├── __init__.py
├── quickstart
│   ├── admin.py
│   ├── apps.py
│   ├── __init__.py
│   ├── migrations
│   │   └── __init__.py
│   ├── models.py
│   ├── serializers.py
│   ├── tests.py
│   └── views.py
├── settings.py
├── urls.py
└── wsgi.py

In the RPM side of packaging this is easy to solve, we can just add the macro %exclude , for users installing from pypi this might be a problem. We caught this here theforeman/pulpcore-packaging#1323

@ggainey
Copy link
Contributor

ggainey commented Nov 12, 2024

Is there an upstream issue opened for this?

@Odilhao
Copy link
Author

Odilhao commented Dec 26, 2024

@ggainey
Copy link
Contributor

ggainey commented Dec 30, 2024

3.15.2 includes a fix for a XSS attack - see encode/django-rest-framework#9435 . I would hesitate to disallow installing it until there's a version with that fix available.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants