Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Colors code on summary should not be printed #1248

Open
neilprosser opened this issue Aug 7, 2024 · 0 comments · May be fixed by #1312
Open

Colors code on summary should not be printed #1248

neilprosser opened this issue Aug 7, 2024 · 0 comments · May be fixed by #1312
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@neilprosser
Copy link

Issue details

Related to #1228. I'm seeing color-related characters in the GitHub step summary when color: always and comment-on-summary: true are both set.

The action allows to enable color with auto (default), raw, never and always.
The action allows to show a comment-on-summary for an update.

It's not possible to enable colors only for the GHA output:

  1. enable color: always
  2. the preview/output in the "Actions" github page is shown with colors
  3. the output in the summary of the check contains color and escape codes

Should be fair to allow colors only for the "Actions" pulumi output and not in the comment of the PR.

Affected area/feature

Pulumi output/colors
@neilprosser neilprosser mentioned this issue Aug 7, 2024
Closed
@justinvp justinvp added the kind/bug Some behavior is incorrect or out of spec label Aug 9, 2024
@byian byian linked a pull request Nov 25, 2024 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ANSI control chars from GitHub step Summary and PR comment byian/pulumi_actions
2 participants
@neilprosser @justinvp