feat: Add option to store docker build cache in ECR image resource #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
Hi, can someone give feedback on this? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cacheToarg to configure the underlying docker cacheTo option, a list of ECR registries is expected.I added some sane defaults to the config, but I would love a feedback on that.
Note that
imageManifest: trueandociMediaTypes: trueare required for ECR registries, but I don't really know if they can cause issues with other types of registries. In any case, I don't think it's a big deal, this is a component tailor-made for AWS solutions.It falls back to the old behaviour (inline cache) if no parameter is specified