Change solar_zenith
to apparent_zenith
when angle is refraction corrected
#2449
Labels
Milestone
Is your feature request related to a problem? Please describe.
The term
solar_zenith
is used for both refraction-corrected (apparent) zenith angles and non-refraction-corrected zenith angles. Example functions fromirradiance.py
:klucher
,haydavies
,reindl
,king
,perez
, andperez_driesse
. Also examples ininfinite_sheds.py
:_shaded_fraction
,get_irradiance_poa
, andget_irradiance
.Describe the solution you'd like
Replace
solar_zenith
withapparent_zenith
for refraction-corrected solar zenith angles. Both terms already have nomenclature entries.Additional context
Incorrect (example):
pvlib-python/pvlib/bifacial/infinite_sheds.py
Lines 417 to 418 in 216386e
pvlib-python/pvlib/irradiance.py
Lines 662 to 664 in 216386e
Correct (example):
pvlib-python/pvlib/clearsky.py
Lines 35 to 36 in 216386e
The text was updated successfully, but these errors were encountered: