Make sure TCP connections end gracefully #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsDrike
added
t: bug
TCP connections establish sessions, and expect graceful shut downs (FIN packet). Make sure on connection close, this packet gets sent. While not having this shutdown functionality should generally not affect us getting the data from the server, or any other functionality of the library, it is a good practice, and some very aggressive firewalls might actually detect and block IPs that don't properly close their TCP connections if this happens multiple times.
ItsDrike
force-pushed
the
graceful-tcp-shutdown
branch
from
bb81bf2 to
f72cc4a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP connections establish sessions, and expect graceful shut downs (FIN packet). Make sure on connection close, this packet gets sent.
While not having this shutdown functionality should generally not affect us getting the data from the server, or any other functionality of the library, it is a good practice, and some very aggressive firewalls might actually detect and block IPs that don't properly close their TCP connections if this happens multiple times.