Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Caching icons #10

Closed
1 task done
hanjinliu opened this issue Oct 23, 2023 · 4 comments · Fixed by #11
Closed
1 task done

Caching icons #10

hanjinliu opened this issue Oct 23, 2023 · 4 comments · Fixed by #11

Comments

@hanjinliu
Copy link

hanjinliu commented Oct 23, 2023

❓ Questions and Help

Hi @tlambert03 , the iconfy support is very nice!

I want to ask if the cached svgs are supposed to be used.
After I ran the following code with internet connection, and ran it later without internet connection, it fails to get the icon even though an svg cache named "mdi_pen-add_color_#..." is created.

from magicgui.widgets import PushButton
btn = PushButton(icon="mdi:pen-add")
btn.show(True)

Thanks!

@tlambert03
Copy link
Member

Yep, that was the intention! Will have to take a look to see what might be failing. You might get more info if you use the superqt widget directly

@tlambert03 tlambert03 transferred this issue from pyapp-kit/magicgui Oct 23, 2023
@tlambert03
Copy link
Member

found the issue! fix needs to happen here in pyconify

@tlambert03
Copy link
Member

the magicgui usage should be fixed with pyconify v0.1.6. it's building now, please try again in ~10 mins

@hanjinliu
Copy link
Author

It's fixed nicely, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants