Skip to content

Use if constexpr #5389

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use if constexpr #5389

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Contributor

@cyyever cyyever commented Sep 29, 2024

Description

Add "if constexpr" support.

@cyyever cyyever marked this pull request as draft September 29, 2024 14:46
@cyyever cyyever force-pushed the if_constexpr branch 8 times, most recently from b547626 to f18b78e Compare September 29, 2024 16:03
@cyyever cyyever marked this pull request as ready for review September 29, 2024 16:07
@rwgk
Copy link
Collaborator

rwgk commented Sep 29, 2024

I'd rather not make these changes, but I'm open to other opinions.

if constexpr is a game changer as an alternative to SFINAE acrobatics.

But AFAIK it does very little or nothing for optimization purposes.

My opinion in this particular case: some extra code noise, no clear benefit.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants