Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adding django-cors-headers to requirements if drf selected #2650

Closed
ghost opened this issue Jul 1, 2020 · 4 comments · Fixed by #2683
Closed

Adding django-cors-headers to requirements if drf selected #2650

ghost opened this issue Jul 1, 2020 · 4 comments · Fixed by #2683
Labels
enhancement

Comments

@ghost
Copy link

ghost commented Jul 1, 2020 •
edited by ghost
Loading

Description

Adding django-cors-headers to requirements/base.txt if drf is selected in the setup process, having it setup in the settings.

Rationale

As far as I know, data from the DRF cannot be consumed without the cors headers properly configured.
@ghost ghost changed the title Adding django-rest key dependencies Adding django-cors-headers to requirements if drf selected Jul 1, 2020
@aadithpm
Copy link
Contributor

Would this be adding django-cors-headers when use_drf is true in {{cookiecutter.project_slug}}/requirements.base.txt or would there be more steps involved? I'd like to take this if it's open.

@browniebroke
Copy link
Member

I think that's all we need to do, yes.

@aadithpm
Copy link
Contributor

Okay, I'll take a look at the guidelines and make a PR. Thanks!

aadithpm added a commit to aadithpm/cookiecutter-django that referenced this issue Jul 17, 2020
@aadithpm
Update requirements to include django-cors-headers with DRF [PR cooki…
f4ce1db 
…ecutter#2650]
@aadithpm aadithpm mentioned this issue Jul 17, 2020
Merged
@aadithpm
Copy link
Contributor

Created a PR here: #2683

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update requirements to include django-cors-headers with DRF [PR #2650] aadithpm/cookiecutter-django
2 participants
@browniebroke @aadithpm