Skip to content

xarray ufuncs #4116

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
keewis opened this issue Jun 1, 2020 · 5 comments · Fixed by #6491
Closed

xarray ufuncs #4116

keewis opened this issue Jun 1, 2020 · 5 comments · Fixed by #6491
Labels

Comments

@keewis
Copy link
Collaborator

keewis commented Jun 1, 2020

The documentation warns that the universal functions in xarray.ufuncs should not be used unless compatibility with numpy < 1.13 is required.

Since we only support numpy >= 1.15: is it time to remove that (already deprecated) module?

Since there are also functions that are not true ufuncs (e.g. np.angle and np.median) and need __array_function__ (or something similar, see #3917), we could also keep those and just remove the ones that are dispatched using __array_ufunc__.

@dcherian
Copy link
Contributor

dcherian commented Jun 1, 2020

Sounds good to me

@keewis
Copy link
Collaborator Author

keewis commented Jun 1, 2020

which suggestion do you mean? Removing the whole module or just the __array_ufunc__ functions?

@keewis
Copy link
Collaborator Author

keewis commented Jun 1, 2020

actually, it seems we might need to wait a bit longer, the deprecation warning says we would remove the __array_function__ ufuncs only after we stopped supporting numpy < 1.17 (see #2615 where the warning was extended). That means we still could remove only a part of the module, or we could wait until we could remove the whole module. I think we should put that warning (removed after support for 1.17 is dropped) into the documentation, too.

@dcherian
Copy link
Contributor

I think we should put that warning (removed after support for 1.17 is dropped) into the documentation, too.

👍

@stale
Copy link

stale bot commented Apr 18, 2022

In order to maintain a list of currently relevant issues, we mark issues as stale after a period of inactivity

If this issue remains relevant, please comment here or remove the stale label; otherwise it will be marked as closed automatically

@stale stale bot added the stale label Apr 18, 2022
@max-sixty max-sixty mentioned this issue Apr 18, 2022
2 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants