Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

LastExitCode Check Reports Failure When Install Was Actually Successful #27

Closed
ryanspletzer opened this issue Apr 29, 2024 · 2 comments · Fixed by #28
Closed

LastExitCode Check Reports Failure When Install Was Actually Successful #27

ryanspletzer opened this issue Apr 29, 2024 · 2 comments · Fixed by #28

Comments

@ryanspletzer
Copy link
Contributor

image

I think this is because $LASTEXITCODE is actually $null and not 0:

image

Will submit a PR to check for $null or 0.
@ryanspletzer ryanspletzer mentioned this issue Apr 29, 2024
Merged
@arzkar
Copy link
Member

arzkar commented Apr 30, 2024

Thanks for the PR. I merge it.
I have been quite busy with IRL work and havent been able to review the open issues.

@ryanspletzer
Copy link
Contributor Author

Glad I could help with a PR. :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust LastExitCode check for null ryanspletzer/pyenv-win-venv
2 participants
@ryanspletzer @arzkar