Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Line flip() #183

Open
itzpr3d4t0r opened this issue Jan 12, 2023 · 0 comments · May be fixed by #222
Open

Add Line flip() #183

itzpr3d4t0r opened this issue Jan 12, 2023 · 0 comments · May be fixed by #222
Labels
submodule:line type:new_api Adds new functionalities to the project

Comments

@itzpr3d4t0r
Copy link
Member

itzpr3d4t0r commented Jan 12, 2023

I propose adding the following new methods to the Line class:

  • flip_x() -> flips the line along the x-axis
  • flip_y() -> flips the line along the y-axis
  • _ip versions

This proposal should follow issue #182, where we rename the following methods:

  • Line.flip() -> flip_endpoints()
  • Line.flip_ip() -> flip_endpoints_ip()

This should be done to avoid confusion with line flipping along the x and y axis.

Alternatively, we could consider adding a general flip()/flip_ip() method that takes an axis as an argument. This would allow users to flip the line along any arbitrary axis.

@itzpr3d4t0r itzpr3d4t0r added type:new_api Adds new functionalities to the project submodule:line labels Jan 12, 2023
@itzpr3d4t0r itzpr3d4t0r moved this to Todo: Line in pygame.geometry Jan 12, 2023
@itzpr3d4t0r itzpr3d4t0r changed the title Add Line flip_x(), flip_y() and/or a general flip() Add Line flip() Jul 22, 2023
@itzpr3d4t0r itzpr3d4t0r changed the title Add Line flip() Add Line flip() Jul 22, 2023
@itzpr3d4t0r itzpr3d4t0r linked a pull request Jul 22, 2023 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
submodule:line type:new_api Adds new functionalities to the project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant