Add copy_metadata to pycountry hook #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based off this thread: http://pyinstaller.47505.x6.nabble.com/PyInstaller-not-working-with-module-pycountry-td3064.html I faced this same issue and used this modified hook, and it worked.
obsidianforensics
requested review from
a team and
rokm
and removed request for
a team
bwoodsend
reviewed
Apr 27, 2021
|
|
||
| # pycountry requires the ISO databases for country data. | ||
| # Tested v1.15 on Linux/Ubuntu. | ||
| # https://pypi.python.org/pypi/pycountry | ||
| datas = collect_data_files('pycountry') | ||
| datas = copy_metadata('pycountry') + collect_data_files('pycountry') |
There was a problem hiding this comment.
Ahh, that solves my confusion here on why the missing data files didn't show up sooner. Because we already had them here but adding another hook overwrites this one.
bwoodsend
requested changes
Apr 27, 2021
There was a problem hiding this comment.
This needs a news entry. Other than that it's good to go...
|
Thanks for the quick review! I've added a news entry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off this thread: http://pyinstaller.47505.x6.nabble.com/PyInstaller-not-working-with-module-pycountry-td3064.html
I faced this same issue, used this modified hook, and it worked.