hooks: sounddevice and soundfile: collect system-installed shared lib #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the sounddevice and soundfile hooks to collect system-installed sndfile and portaudio shared libraries in cases when the libraries are not bundled with the package (i.e., linux PyPI wheels and Anaconda-provided packages on all OSes).
bwoodsend
approved these changes
Sep 20, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
sounddeviceandsoundfilehooks to collect system-installedsndfileandportaudioshared libraries in cases when the libraries are not bundled with the package (i.e., linux PyPI wheels and Anaconda-provided packages on all OSes).Fixes the collection part of pyinstaller/pyinstaller#7065.