Add a hook for torchvision.ops #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduces the error from pyinstaller/pyinstaller#5386.
Add a hidden import of torchvision._C extension module that we fail to pick up automatically. This extension module is required in functions from torchvision.ops.* modules, where its absence causes the _assert_has_ops() call to fail. Fixes the failing test_torchvision_nms. Fixes pyinstaller/pyinstaller#5386.
rokm
requested review from
a team and
bwoodsend
and removed request for
a team
|
Can you run the CI run tests? Maybe just do one version of Python? |
|
Here's the run for the latest stable version under python 3.9 on Windows and Linux: https://github.com/rokm/pyinstaller-hooks-contrib/runs/1557959180?check_suite_focus=true. |
bwoodsend
approved these changes
Dec 15, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a hidden import of
torchvision._Cextension module that we fail to pick up automatically. This extension module is required in functions fromtorchvision.ops.*modules, where its absence causes the_assert_has_ops()call to fail.Fixes pyinstaller/pyinstaller#5386