Fix a false positive for unused-variable when there is an import in a if TYPE_CHECKING: block and allow-global-unused-variables is set to no in the configuration. (#8713) (#8744)

Closes #8696

(cherry picked from commit e5584d5)

Co-authored-by: Mark Byrne <31762852+mbyrnepr2@users.noreply.github.com>

Author: github-actions[bot]

doc/whatsnew/fragments/8696.false_positive

@@ -0,0 +1,3 @@
+Fix a false positive for ``unused-variable`` when there is an import in a ``if TYPE_CHECKING:`` block and ``allow-global-unused-variables`` is set to ``no`` in the configuration.
+
+Closes #8696

pylint/checkers/variables.py

@@ -3040,6 +3040,8 @@ def _check_globals(self, not_consumed: dict[str, nodes.NodeNG]) -> None:
             return
         for name, node_lst in not_consumed.items():
             for node in node_lst:
+                if in_type_checking_block(node):
+                    continue
                 self.add_message("unused-variable", args=(name,), node=node)
 
     # pylint: disable = too-many-branches

tests/functional/u/unused/unused_global_variable2.py

@@ -1,2 +1,11 @@
 # pylint: disable=missing-docstring
+
+
+from typing import TYPE_CHECKING
+
+
+if TYPE_CHECKING:
+    import math
+
+
 VAR = 'pylint'  # [unused-variable]

tests/functional/u/unused/unused_global_variable2.txt

@@ -1 +1 @@
-unused-variable:2:0:2:3::Unused variable 'VAR':UNDEFINED
+unused-variable:11:0:11:3::Unused variable 'VAR':UNDEFINED