Skip to content

Cleanup after we drop support for Python 3.7 #6306

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
3 tasks done
Pierre-Sassoulas opened this issue Apr 14, 2022 · 3 comments · Fixed by #8811
Closed
3 tasks done

Cleanup after we drop support for Python 3.7 #6306

Pierre-Sassoulas opened this issue Apr 14, 2022 · 3 comments · Fixed by #8811
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow python 3.7
Milestone

Comments

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Apr 14, 2022

When we do drop support because 3.7 has reached its end of life after 2023-06-27, we'll need to do some cleanup:

@Pierre-Sassoulas Pierre-Sassoulas added the Maintenance Discussion or action around maintaining pylint or the dev workflow label Apr 14, 2022
@jacobtylerwalls jacobtylerwalls changed the title Cleanup atfer we drop support for Python 3.7 Cleanup after we drop support for Python 3.7 Apr 14, 2022
@cdce8p cdce8p removed the python 3.8 label Apr 15, 2022
@cdce8p
Copy link
Member

cdce8p commented Apr 15, 2022

EOL for 3.7 is scheduled for 2023-06-27.

Once 3.7 is dropped, the most notable changes for us are probably

  • We can start using assignment expressions
  • Final, Literal, TypedDict can be imported from typing directly
  • We no longer need import guards for functools.cached_property

@Pierre-Sassoulas
Copy link
Member Author

We also need to upgrade functional tests that are exclusive to python 3.7 so they use py-version instead.

@jacobtylerwalls
Copy link
Member

We also need to upgrade functional tests that are exclusive to python 3.7 so they use py-version instead.

For future reference, this was done when adjusting the max_pyver test setting, not the min_pyver setting. We discussed it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow python 3.7
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants