-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[primer] Flaky results from inference differences #8790
Comments
I'll reopen if I see this again. |
I had a long term plan to make the primer prettier by showing only what really changed, but my work branch is basically impossible to rebase at this point. Should have concluded the MR when I had the chance. It's not super simple to do, you need to decide if a message is a new message or a modified message from information that is not very stable. Basically some fields are more important than others. Also the commit is not set for the primed repo, which make this a shaky ground to decide from the json we have. And there's of course a lot of markdown output fine tunning to do. |
Still happening, not particularly subtle. See recent runs like #8824 (comment), on a PR only touching pyreverse 😭 . |
I have reason to believe #8872 made this significantly more deterministic. Will reopen if I see it again. |
See #8758 (comment) for a recent example of subtle differences in messages comparing unequal and causing noisy, irrelevant primer output.
Messages like
invalid-name
anddeprecated-typing-alias
seem to be the worst offenders.The text was updated successfully, but these errors were encountered: