Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Images in NBs are compressed #671

Open
twiecki opened this issue Jul 6, 2024 · 5 comments
Open

Images in NBs are compressed #671

twiecki opened this issue Jul 6, 2024 · 5 comments

Comments

@twiecki
Copy link
Member

twiecki commented Jul 6, 2024

Images in NBs are compressed, this is a sphinx issue that popped up e.g. here:
pymc-labs/pymc-marketing#667

@twiecki
Copy link
Member Author

twiecki commented Jul 6, 2024

Oh, supposedley it was fixed in #660 but still seeing it here: https://www.pymc.io/projects/examples/en/latest/gaussian_processes/HSGP-Advanced.html
image

@twiecki
Copy link
Member Author

twiecki commented Jul 6, 2024

Oh, I accidentally committed the fix to main 1258d5f. Anyway that hopefully takes care of it. The issue is, I'm fairly certain, that myst-nb released 1.1.1 with the bug still present.

@twiecki twiecki closed this as completed Jul 6, 2024
@OriolAbril
Copy link
Member

The fix was definitely merged before the release 🤔. But there were a couple PRs to fix it that were merged together, maybe something went wrong. I'll reopen so we remember to check

@OriolAbril OriolAbril reopened this Jul 6, 2024
@OriolAbril
Copy link
Member

I re-rendered the mwe I generated for the issues and I don't see any problem with myst-nb 1.1.1: https://oriol-sphinx-playground.readthedocs.io/en/image_metadata_a/.

I'll open a PR to see if 1) the PR preview renders correctly, 2) it is using the right versions

@drbenvincent
Copy link
Contributor

FYI myst-nb is now on version 1.2.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants