Skip to content

Create GH Action to build & update the Docker image #5939

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
michaelosthege opened this issue Jul 2, 2022 · 6 comments
Closed

Create GH Action to build & update the Docker image #5939

michaelosthege opened this issue Jul 2, 2022 · 6 comments

Comments

@michaelosthege
Copy link
Member

In #5881 the Dockerfile was updated to work for PyMC v4+, and @danhphan also pushed them to https://hub.docker.com/r/pymc/pymc/tags manually.

We should add a GitHub Actions pipeline to automatically build a new image on new releases, and push it tagged as latest and with the version.

@twiecki
Copy link
Member

twiecki commented Jul 3, 2022

@danhphan Is this something you can help with?

@danhphan
Copy link
Member

danhphan commented Jul 5, 2022

Hi @twiecki I would love to do it, but current really busy as I have two papers' submission deadline at the end of this month. And also need to focus on the GSoC project.

Could be great if someone can go ahead to do it. Otherwise, I will do it early next month. Thanks all.

@symeneses
Copy link
Contributor

I would like to work on this 🙌🏽

@5hv5hvnk
Copy link
Member

5hv5hvnk commented Jul 10, 2022

@symeneses I didn't realise you were working on it too
I wrote some of the script haven't tested it yet (but I am hopeful it will work fine) you can go through it once

name: Push Dockerfile to docker docker hub
on:
	push:
		paths:
			- 'scripts/Dockerfile'

jobs:
	build-container:
		name: Build docker image
		runs-on: ubuntu-latest
		steps:
			- name: Checkout code
			  uses: actions/checkout@v2
			- name: Publish tp docker hub
			  uses: docker/build-push-actions@v1
			  with:
			  	username: ${{ secrets.Docker-Username}}
			  	password: ${{ secrets.Docker-Password}}
			  	repository: pymc/pymc
			  	tags: latest

We will have to add secrets for docker password and username rest seems fine to me

@symeneses
Copy link
Contributor

@5hv5hvnk all good, I just opened a PR for this #5966.

@michaelosthege
Copy link
Member Author

Assuming that the fixes from #5977 will succeed, I'm closing this 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

5 participants