Skip to content

Run mypy job with Python 3.11 once it is supported #240

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ricardoV94 opened this issue Mar 10, 2023 · 5 comments · Fixed by #277
Closed

Run mypy job with Python 3.11 once it is supported #240

ricardoV94 opened this issue Mar 10, 2023 · 5 comments · Fixed by #277

Comments

@ricardoV94
Copy link
Member

Description

We should revert c3bfe66 once mypy is sorted out (and if it's not mypy fault, then whatever we are doing wrong).

Maybe related to python/mypy#12840, maybe we need to open a new issue over there?

@ricardoV94 ricardoV94 changed the title Run mypy job in Python 3.11 once it is supported Run mypy job with Python 3.11 once it is supported Mar 10, 2023
@ricardoV94
Copy link
Member Author

ricardoV94 commented Mar 11, 2023

I didn't save the run, but this was the error:

 [pytensor/link/c/exceptions.py]
 pytensor/link/c/exceptions.py:1: error: Module "setuptools._distutils.errors" has no attribute "CompileError"

Even though it's there in main
https://github.com/pypa/setuptools/blob/245d72a8aa4d47e1811425213aba2a06a0bb64fa/setuptools/_distutils/errors.py#L112-L113

@ricardoV94
Copy link
Member Author

It also cropped up on a Python 3.10 job now, so it must be something else: https://github.com/pymc-devs/pytensor/actions/runs/4712555504/jobs/8357675677?pr=276

@michaelosthege do you have any ideas?

@maresb
Copy link
Contributor

maresb commented Apr 17, 2023

Looks like a problem with setuptools-types which would be fixed by python/typeshed#10057 and #277

@ricardoV94
Copy link
Member Author

Awesome 😎

@maresb
Copy link
Contributor

maresb commented Apr 17, 2023

My typeshed PR has already been merged. A quick glance at their GH Actions suggests that there will soon be an automatic release to https://pypi.org/project/types-setuptools/#history. Once that's out, #277 should pass.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants