You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following #1246, these components should be integrated into the MMM class.
This might also support the previous boolean flags for time_varying_intercept and time_varying_media but also include passing of either of the classes, HSGP or HSGPPeriodic
frompymc_marketing.priorimportPriorfrompymc_marketing.mmmimportMMM, HSGPPeriodic, GeometricAdstock, LogisticSaturationmedia_hsgp=HSGPPeriodic(
scale=Prior("HalfNormal", sigma=1),
ls=30, # daysperiod=365, # days
...,
dims="date",
)
mmm=MMM(
date_column=...,
channel_columns=...,
adstock=GeometricAdstock(l_max=10),
saturation=LogisticSaturation(),
time_varying_intercept=True, # Previous behavior or updated with HSGP behind the scenestime_varying_media=media_hsgp,
...,
)
The complicated aspect is that the current implementation of GPs will perform a softplus transformation on that variable. Would that be explicit now? Or handled for all custom classes within the MMM class?
Following #1246, these components should be integrated into the
MMM
class.This might also support the previous boolean flags for
time_varying_intercept
andtime_varying_media
but also include passing of either of the classes,HSGP
orHSGPPeriodic
The complicated aspect is that the current implementation of GPs will perform a
softplus
transformation on that variable. Would that be explicit now? Or handled for all custom classes within theMMM
class?Thoughts on this? @juanitorduz @cetagostini
The text was updated successfully, but these errors were encountered: